Re: [RFA] Async mode fixes.

[Vladimir Prus <vladimir at codesourcery dot com>]

On Friday 14 March 2008 21:26:29 Daniel Jacobowitz wrote:
> On Wed, Mar 05, 2008 at 10:27:28AM +0300, Vladimir Prus wrote:
> > +	  /* If any exception escaped to here, we better enable
> > +	     stdin.  Otherwise, any command that calls async_disable_stdin,
> > +	     and the can throw, will leave stdin inoperable.  */
> 
> and can throw?

"and then throws", actually.
> 
> >      case INF_EXEC_COMPLETE:
> > -      /* Is there anything left to do for the command issued to
> > -         complete? */
> > +
> > +      /* This is the first thing to do -- so that continuations know that
> > +	 the target is stopped.  For example, command_line_handler_continuation
> > +	 will run breakpoint commands, and if we thing that the target is
> > +	 running, we'll refuse to execute most command.  MI continuation
> > +	 presently is target_executing to either print or not print *stopped.  */
> > +      target_executing = 0;
> 
> "if we think", "most commands".  "is" -> "uses" in the last line, right?

right.


> 
> > @@ -1005,10 +1006,28 @@ static void
> >  signal_command (char *signum_exp, int from_tty)
> 
> Two spaces after periods in this function :-)
> 
> > +/* Do any commands attached to breakpoint we stopped at. Only if we
> > +   are always running synchronously. Or if we have just executed a
> > +   command that doesn't start the target. */
> 
> Here too.
> 
> > +static void
> > +command_line_handler_continuation (struct continuation_arg *arg)
> > +{
> > +  extern int display_time;
> > +  extern int display_space;
> > +
> > +  long time_at_cmd_start  = arg->data.longint;
> > +  long space_at_cmd_start = arg->next->data.longint;
> > +
> > +  bpstat_do_actions (&stop_bpstat);
> > +  /*do_cleanups (old_chain); *//*?????FIXME????? */
> 
> Clean up this, please.

Oh, this is not mine, I've just moved command_line_handler_continuation
to a different module. Anyway, some of later patches of mine removes
that line as not necessary, and I might as well do it now.

> 
> Other than that, this can go in now.  Thanks.  Between you and Nick
> and Pedro I'm sure we'll have async mode working again soon.

Thanks, checked in.

- Volodya