This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Use compilation unit's address size in dwarf2expr.c and dwarf2loc.c
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: kevinb at redhat dot com (Kevin Buettner), drow at false dot org, jimb at read-bean dot com
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 17 Mar 2008 20:10:23 +0100 (CET)
- Subject: Re: [RFC] Use compilation unit's address size in dwarf2expr.c and dwarf2loc.c
Kevin Buettner wrote:
> On Mon, 17 Mar 2008 14:35:03 +0100 (CET)
> "Ulrich Weigand" <uweigand@de.ibm.com> wrote:
>
> > Here is my current patch, based on Jim Blandy's orignal patch and on
> > Dan Jacobowitz' patch to fix DW_CFA_set_loc. With the exception of
> > the one FIXME in decode_frame_entry_1, this patch fixes all issues
> > related to dwarf address size handling that I'm aware of ...
> >
> > Tested on i386-linux, s390-linux, and s390x-linux.
> >
> > Does this look OK?
>
> I've tested your patch against the mips target upon which I was
> seeing address size related problems. The results are comparable
> to those obtained using the patch that I posted.
>
> So, as far as I'm concerned, your patch is okay to commit.
Thanks for testing!
Dan, Jim, if this is OK with you I'll go ahead and commit this
version of the patch ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com