This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] Fix calls to frame_base_find_by_frame in frame.c (?)


Hi Daniel,

I noticed a regression while converting alpha-osf to the value-based
unwinding approach, and it looks like frame_base_find_by_frame was
changed to take a this_frame but the callers were still left passing
a next_frame. As a result, we ended up selecting the wrong frame
base unwinder for a one of our frames, leading to the wrong value
being printed for the one argument.

2008-05-08  Joel Brobecker  <brobecker@adacore.com>

        * frame.c (get_frame_base_address, get_frame_locals_address)
        (get_frame_args_address): Pass the correct frame when calling
        frame_base_find_by_frame.

Tested on x86-linux. I also tested this on alpha-osf after my updates
for the new value-based unwinding - but because I haven't been able
to run the testsuite on this platform for a while now, I used AdaCore's
GDB testsuite as the reference.

-- 
Joel

Attachment: frame.c.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]