This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Report the main thread.


Joel Brobecker writes:
 > > Now that Joel has requested that I use observer_attach_new_thread for
 > > annotations this approach doesn't only produce MI output so it needs to
 > > be conditioned on MI:
 > > 
 > > @@ -124,6 +124,10 @@ add_thread_silent (ptid_t ptid)
 > >    tp->num = ++highest_thread_num;
 > >    tp->next = thread_list;
 > >    thread_list = tp;
 > > +
 > > +  if (ui_out_is_mi_like_p (uiout))
 > > +    observer_notify_new_thread (tp);
 > > +
 > >    return tp;
 > >  }
 > 
 > I am afraid this is not right. Could you elaborate more on what
 > the problem is?

The problem is that Vladimir's patch means that the main thread is now
reported, not only for MI, but whenever the new_thread observer is registered.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]