This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Remove addr, endaddr, offset from obj_section
- From: Pedro Alves <pedro at codesourcery dot com>
- To: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 16 May 2008 19:57:46 +0100
- Subject: Re: [RFC] Remove addr, endaddr, offset from obj_section
- References: <200805161832.m4GIWS30028466@d12av02.megacenter.de.ibm.com>
A Friday 16 May 2008 19:32:28, Ulrich Weigand wrote:
> Pedro Alves wrote:
>
> > I seems the comment is a bit offbase. The reader still applies
> > ANOFFSET to the symbols, so psymtab->symtab expansion time sees
> > the correct section offsets. It feels like the xcoff reader
> > should cope with the section offsets != 0 internally, and not
> > do this ignoring, but since I don't have access to any AIX system,
> > I didn't investigate that further. But I do think things should
> > still work as they used to.
>
> I haven't looked into the patch in detail, but just one comment here:
> The guard on this block of code is
> #ifndef DEPRECATED_IBM6000_TARGET
> so it is executed on every target *but* AIX. Removing it doesn't
> change the behaviour on AIX, so there should be no need to specially
> test on AIX.
>
Yes, I believe that's right. To make it clear, I was refering
to investigating why xcoff_symfile_offsets ignores the passed-in
offsets (which can come from a add-symbol-file command from the
user), and make it not do that. I don't know much xcoff, and why
that was needed, but I had the impression we could get around
needing to do that.
> (In any case, I'll be happy to test patches on AIX if necessary.)
(Thanks! Nice to know that.)
--
Pedro Alves