This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: remove global stop_bpstat dependency from breakpoints module
- From: Daniel Jacobowitz <drow at false dot org>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 5 Jun 2008 14:03:31 -0400
- Subject: Re: remove global stop_bpstat dependency from breakpoints module
- References: <200805080222.04976.pedro@codesourcery.com>
On Thu, May 08, 2008 at 02:22:04AM +0100, Pedro Alves wrote:
> I had missed this on the non-stop series. I'll need to context switch
> stop_bpstat in non-stop mode, because there, we'll have simultaneous
> independant stop events, one per thread, and each should have its own
> stop_bpstat. That's a small change to patch 4 in series I posted.
The implementation makes it look like this will work for watchpoints
too. If we want to preserve that - which is not the documented
behavior - then I agree we should context-switch stop_bpstat. But
I'm thinking it makes more sense to restrict this to breakpoints,
and search for a breakpoint at the current PC.
What do you think? Also, does that remove the only reason to
context-switch stop_bpstat? If so, we don't need this patch at all.
> One way to fix it, would be to also loop through all threads to update
> their version of stop_bpstat, but I'd like better.
If we do need to context-switch stop_bpstat, it seems like checking
all of those would be simpler than this patch as posted.
--
Daniel Jacobowitz
CodeSourcery