This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] PPC - Stepping off breakpoints in non-stop mode
- From: Pedro Alves <pedro at codesourcery dot com>
- To: luisgpm at linux dot vnet dot ibm dot com
- Cc: Daniel Jacobowitz <drow at false dot org>, gdb-patches at sourceware dot org
- Date: Tue, 24 Jun 2008 15:03:58 +0100
- Subject: Re: [PATCH] PPC - Stepping off breakpoints in non-stop mode
- References: <1209753019.7131.29.camel@gargoyle> <20080605200249.GH25085@caradoc.them.org> <1212768014.10042.60.camel@gargoyle>
A Friday 06 June 2008 17:00:14, Luis Machado wrote:
> On Thu, 2008-06-05 at 16:02 -0400, Daniel Jacobowitz wrote:
> > Sorry, the problem Pedro spotted is still there :-(
>
> How about the attached one?
>
FWIW, I'm happy with this version.
> + if ((opcode == B_INSN) || (opcode == BC_INSN) || (opcode == BXL_INSN))
Strictly speaking, the extra parens violate the GNU coding
conventions, as they aren't really needed here.
> + if (link_register_bit)
> + {
> +
> + regcache_cooked_write_unsigned (regs,
Unneeded extra blank line here.
--
Pedro Alves