This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [continuation args 2/2] Make continuation args not leak
- From: Daniel Jacobowitz <drow at false dot org>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 12 Jul 2008 14:54:48 -0400
- Subject: Re: [continuation args 2/2] Make continuation args not leak
- References: <200807112138.55781.pedro@codesourcery.com>
On Fri, Jul 11, 2008 at 09:38:55PM +0100, Pedro Alves wrote:
> + struct cleanup **as_cleanup_p = (struct cleanup **) &cmd_continuation;
> + make_cleanup_ftype *continuation_hook_ftype = continuation_hook;
ftype stands for function type, and our convention is to use it for
types only. So please don't use it in the name of a variable.
continuation_fn?
> +static void
> +finish_command_continuation_free_arg (void *arg)
> +{
> + /* NOTE: See finish_command_continuation. This would go away, if
> + this suppressing is made a thread property. */
> + suppress_stop_observer = 0;
> +}
Doesn't it still need to call xfree?
Otherwise OK.
--
Daniel Jacobowitz
CodeSourcery