Re: [RFA] set print symbol-loading on|off

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Thu, 10 Jul 2008 13:37:01 -0700 (PDT)
> From: dje@google.com (Doug Evans)
> 
> Along the lines of "set print thread-events on|off",
> this option lets one turn off symbol loading messages.
> If the app has *lots* of shared libraries, these messages
> can be more noise than signal.

Thanks.

> --- NEWS	10 Jul 2008 16:44:47 -0000	1.280
> +++ NEWS	10 Jul 2008 20:16:31 -0000
> @@ -68,6 +68,10 @@ find [/size-char] [/max-count] start-add
>      val1 [, val2, ...]
>    Search memory for a sequence of bytes.
>  
> +set print symbol-loading
> +show print symbol-loading
> +  Control printing of symbol loading messages.

This is okay.

> -	  printf_unfiltered (_("Reading symbols from %s..."), name);
> -	  wrap_here ("");
> -	  gdb_flush (gdb_stdout);
> +          if (print_symbol_loading)
> +	    {
> +	      printf_unfiltered (_("Reading symbols from %s..."), name);
> +	      wrap_here ("");
> +	      gdb_flush (gdb_stdout);
> +	    }

I'm not sure doing this in complete silence is a good idea.  You've
shut up GDB, but this phase could take a long time, during which GDB
will appear to be hung.  How about printing a single message, like
"Reading symbols ..."?

> +  add_setshow_boolean_cmd ("symbol-loading", no_class,
> +                           &print_symbol_loading, _("\
> +Set printing of symbol loading messages."), _("\
> +Show printing of symbol loading messages."), NULL,

This is not enough detail.  As written, this doc string doesn't really
document anything in a useful manner.  Please add an explanation of
what this does, e.g. "When ON (the default), GDB will print messages
about loading symbols from shared libraries and debug info files."

> Index: doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v

This part is okay.  Thanks.