This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Delete breakpoint.c local variables


Michael Snyder wrote:
On Mon, 2008-08-04 at 16:44 +0100, Phil Muldoon wrote:
Michael Snyder wrote:
On Wed, 2008-07-30 at 18:03 +0100, Phil Muldoon wrote:
While stepping through breakpoint.c longjmp breakpoint code, I noticed some small trivial unused local variables. Patch to fix.

2008-07-30 Phil Muldoon <pmuldoon@redhat.com>

* breakpoint.c (create_longjmp_breakpoint): Remove unused struct
breakpoint.
(set_longjmp_breakpoint): Likewise.
OK, thanks. Please commit
Michael,

Hi and thanks for the review. I am in fact a complete newbie to GDB development, and do not have commit after approval authorization. So could you, or someone else please commit the patch and ChangeLog?

OK, it's done.


How odd, I thought I had seen your name in a changelog before.

You do have an account on the sourceware machine, you know...
Or is that for a different project?

Yep that was for Frysk. But thanks for committing this. Just so happens that everything was straightened out for me to do commit after approval last night. So hopefully this is the first - and last time - you will have to do the actual commit on my behalf after approval ;)


Regards

Phil


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]