This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Use is_stopped, instead of !is_running
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 9 Aug 2008 18:30:45 +0400
- Subject: Re: Use is_stopped, instead of !is_running
- References: <200807291459.12056.pedro@codesourcery.com>
> 2008-07-29 Pedro Alves <pedro@codesourcery.com>
>
> * gdbthread.h: Add comments.
> * stack.c (get_selected_block): Return 0 on an exited thread.
> * top.c (execute_command): Check for is_stopped, not !is_running.
> * event-top.c (command_handler): Likewise.
Looks OK to me. It took me a while to decide that it was OK to leave
one instance inside inf-loop.c, but I think the !is_running there is OK.
--
Joel