This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Remove deprecated_set_value_type (part 1)
- From: "Rob Quill" <rob dot quill at gmail dot com>
- To: "Mark Kettenis" <mark dot kettenis at xs4all dot nl>, rob dot quill at gmail dot com, gdb-patches at sourceware dot org, "Daniel Jacobowitz" <drow at false dot org>
- Date: Sat, 9 Aug 2008 16:10:13 +0100
- Subject: Re: Remove deprecated_set_value_type (part 1)
- References: <baf6008d0801202053w5aaa9ee1pf4cde2b15ec8fa53@mail.gmail.com> <20080129195506.GE9019@caradoc.them.org> <baf6008d0801300338n119405c1x9d6507001ea4e945@mail.gmail.com> <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl> <20080226012037.GA4456@caradoc.them.org> <baf6008d0807271216n3b7b2d39h30bc2529fe23bebd@mail.gmail.com>
Ping :)
Rob
2008/7/27 Rob Quill <rob.quill@gmail.com>:
> 2008/2/26 Daniel Jacobowitz <drow@false.org>:
>> On Wed, Jan 30, 2008 at 07:04:40PM +0100, Mark Kettenis wrote:
>>> There are some code style problems here too, and although they're not
>>> your fault, it'd be nice to fix them while you're there. Actually, it
>>> looks to me as if the temparg variable is completely redundant now, so
>>> the above could be simplified to
>>>
>>> val = value_addr (val);
>>
>> Mark's right; also, there are still formatting problems with the patch
>> that I commented on the last time I reviewed it :-( Rob, let me know if
>> you'd like me to point them out individually.
>
> Hi all,
>
> This has been a long time coming, but I've finally managed to find
> some time to get this finished. Please find attached what I believe
> should be the final version of this patch, checked against the current
> head with no regressions.
>
> Rob
>