Re: Patches to build on DJGPP

[Pedro Alves <pedro at codesourcery dot com>]

On Sunday 10 August 2008 16:36:39, Mark Kettenis wrote:
> >
> > Index: src/gdb/buildsym.c
> > ===================================================================
> > --- src.orig/gdb/buildsym.c	2008-08-09 20:55:28.000000000 +0100
> > +++ src/gdb/buildsym.c	2008-08-09 22:27:04.000000000 +0100
> > @@ -547,7 +547,7 @@ start_subfile (char *name, char *dirname
> >  	  && !IS_ABSOLUTE_PATH (subfile->name)
> >  	  && subfile->dirname != NULL)
> >  	subfile_name = concat (subfile->dirname, SLASH_STRING,
> > -			       subfile->name, NULL);
> > +			       subfile->name, (void*) NULL);
> >        else
> >  	subfile_name = subfile->name;
>
> There's a space missing; should be (void *) instead of (void*).
> However, I think one can argue that one should use (char *) here.
> Same for xml-tdep.c further down.

Thanks, I will change it.  I see you've indeed fixed similar cases
before for OpenBSD/gcc4.

>
> > Index: src/gdb/posix-hdep.c
> > ===================================================================
> > --- src.orig/gdb/posix-hdep.c	2008-08-09 20:55:39.000000000 +0100
> > +++ src/gdb/posix-hdep.c	2008-08-09 22:27:04.000000000 +0100
> > @@ -24,6 +24,12 @@
> >
> >  #include "gdb_select.h"
> >
> > +#ifdef __GO32__
> > +/* DJGPP defines the fd_set type in sys/types.h, but `select' goes
> > +   here. */
> > +# include <time.h>
> > +#endif
> > +
> >  /* The strerror() function can return NULL for errno values that are
> >     out of range.  Provide a "safe" version that always returns a
> >     printable string. */
>

> Like I wrote in another reply, I think we should include <sys/time.h>
> in gdb_select.h, instead of adding this #ifdef __GO32__ here.

I just checked that this in gdb_select.h, and dropping the include <time.h>
in posix-hdep.c buils fine in DJGPP.

--- src.orig/gdb/gdb_select.h
+++ src/gdb/gdb_select.h
@@ -22,10 +22,8 @@
 
 #ifdef HAVE_SYS_SELECT_H
 #include <sys/select.h>
-#endif
-
-#ifdef HAVE_SYS_TYPES_H
-#include <sys/types.h>
+#else
+#include <sys/time.h>
 #endif
 
We already include sys/time.h in common code without a HAVE_SYS... 
wrapper (event-loop.c), so I guess this is the best to do here?

-- 
Pedro Alves