This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Add a third mode to "breakpoints always-inserted", and make it the default
On Tuesday 12 August 2008 21:11:33, Daniel Jacobowitz wrote:
> On Tue, Aug 12, 2008 at 09:07:19PM +0100, Pedro Alves wrote:
> > > Also, it would be helpful to have an index entry here, something like
> > >
> > > @cindex non-stop mode, and @code{breakpoint always-inserted}
> >
> > Done, and done, I think.
>
> No, you added:
> > +@cindex non-stop mode
>
> I'm sure that one doesn't go here :-)
>
Where does it go then? I generated html, and I see two "non-stop mode"
index entries, one of them points here, to the auto option, the other
points to the "set non-stop mode" option.
> > + if (always_inserted_mode == always_inserted_auto)
> > + fprintf_filtered (file,
> > + _("Always inserted breakpoint mode is %s (currently %s).\n"),
> > + value, non_stop ? "on" : "off");
>
> I suggest calling breakpoints_always_inserted_mode here instead of
> checking non_stop.
Sure.
>
> Otherwise, the code looks fine - though I'd like to reach an agreement
> with Vladimir about set non-stop first.
Certainly.
--
Pedro Alves