This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix in features/Makefile
- From: Daniel Jacobowitz <drow at false dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 24 Aug 2008 18:37:51 -0400
- Subject: Re: RFA: fix in features/Makefile
- References: <m3prnycmh4.fsf@fleche.redhat.com>
On Sun, Aug 24, 2008 at 12:11:03PM -0600, Tom Tromey wrote:
> When regenerating some files in features using features/Makefile, I
> saw some strange control characters show up at the start of the
> generated files.
>
> This patch changes features/Makefile to use gdb's logging feature
> rather than redirection to create the output files. This fixed the
> problem I saw.
But why did it? If you can't redirect GDB's output, something's
wrong.
> This patch also makes it so that the .c files are always rebuilt in
> response to a 'make'. Without the FORCE code, make was not running
> the rule for me.
If you're going to change the generating code, IMO it's reasonable to
remove and remake the generated files by hand...
> Also, it would be nice if someone documented which .xml->.c
> translations are to be checked in. I ran the rule with XMLTOC set to
> all the .xml files under features, and I got a bunch of new files that
> aren't in the repository. IMO the canonical list ought to be set in
> features/Makefile somewhere.
Sounds reasonable. It's all the ones with a full target description
(rather than a single feature), I believe.
--
Daniel Jacobowitz
CodeSourcery