This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] step over permanent breakpoint
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Aleksandar Ristovski <aristovski at qnx dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 2 Sep 2008 22:54:17 +0200
- Subject: Re: [patch] step over permanent breakpoint
- References: <g7cbe2$k68$1@ger.gmane.org> <20080818110709.GD16894@adacore.com> <48AAE8D7.7040608@qnx.com> <20080825163516.GA31707@adacore.com> <48BD5D64.1050708@qnx.com>
> >Also, I don't completely understand the ".1" part of your regexp. And
> >the gdb_test_multiple documentation also says that you should include
> >the final newline and prompt. So I suggest:
> >
> > -re ".*($hex).*$gdb_prompt $".
> It was a shortcut for "\\\$1".
> Changed.
Haaaaaa, you meant to match the "$<number>" part of the output, right?
> 2008-09-02 Aleksandar Ristovski <aristovski@qnx.com>
>
> * breakpoint.c (breakpoint_init_inferior): Mark as not inserted only
> non-permanent breakpoints.
> (bpstat_stop_status): Change enable_state to bp_disabled only for
> non-permanent breakpoints.
> (bp_loc_is_permanent): New function.
> (create_breakpoint): Check if the location points to a permanent
> breakpoint and if it does, make breakpoint permanent.
> (update_breakpoint_locations): Make sure new locations of permanent
> breakpoints are properly initialized.
> * i386-tdep.c (i386_skip_permanent_breakpoint): New function.
> (i386_gdbarch_init): Set gdbarch_skip_permanent_breakpoint.
This is OK, just remember to make a couple of tiny little adjustments:
> + /* Update locationos of permanent breakpoints. */
^^^^^^^^^^ spelling
> @@ -8152,6 +8189,7 @@ single_step_breakpoint_inserted_here_p (
> return 0;
> }
>
> +
>
> /* This help string is used for the break, hbreak, tbreak and thbreak commands.
> It is defined as a macro to prevent duplication.
This hunk (adding an extra new line before the ^L is unnecessary).
> 2008-09-02 Aleksandar Ristovski <aristovski@qnx.com>
>
> * gdb.arch/i386-bp_permanent.exp: New test.
This is also OK.
--
Joel