This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] add ppc testcase to test fpscr
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Tue, 2 Sep 2008 23:39:49 +0200
- Subject: Re: [rfc] add ppc testcase to test fpscr
- References: <1219360611.8989.6.camel@localhost.localdomain> <20080821233115.GA1239@caradoc.them.org> <1219362081.29526.2.camel@localhost.localdomain> <20080822024659.GA12951@caradoc.them.org> <1219428669.8167.2.camel@localhost.localdomain>
> 2008-08-22 Thiago Jung Bauermann <bauerman@br.ibm.com>
>
> Add FPSCR tests.
>
> * gdb.arch/ppc-fp.exp: New file.
> * gdb.arch/ppc-fp.c: New file.
I didn't see anyone actually review the patch so I took a look.
Looks OK to me, but I'm really wonderng why you added a '\r' at
the end of the expected output in our gdb_test calls. For instance:
> +gdb_test "print \$fpscr" " = 0\r" "FPSCR is all zeroes"
Usually, I just do:
gdb_test "print \$fpscr" " = 0" "FPSCR is all zeroes"
Is there something specific that you are trying to do with the '\r'?
> +#include <stdio.h>
Is the use of stdio necessary in this case. If you can do without,
then this would allow us to run this testcase in the bareboard case
(powerpc-elf). Not strictly necessary, but nice to have...
--
Joel