This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFA: fix minor memory leak in symfile.c

From: Joel Brobecker <brobecker at adacore dot com>
To: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
Date: Wed, 17 Sep 2008 18:04:18 -0700
Subject: Re: RFA: fix minor memory leak in symfile.c
References: <m3bpysugn4.fsf@fleche.redhat.com> <20080913171723.GH3714@adacore.com> <m37i9gudzh.fsf@fleche.redhat.com> <20080913223455.GB19625@adacore.com> <m3r67nu0bn.fsf@fleche.redhat.com> <1221433676.17278.1.camel@localhost.localdomain>

> When I added that use of asprintf, I checked that libiberty provides it
> if the underlying OS doesn't. I thought we could use anything covered by
> libiberty. Maybe not?

Not sure. I don't think that it is a portability issue, but rather
to provide an interface where any issues causes an error to be thrown.
That way, no need to check the pointer returned, nor the status code,
and thus it's not possible to forget. I think it's the same as xmalloc.

-- 
Joel

Follow-Ups:
- Re: RFA: fix minor memory leak in symfile.c
  - From: Daniel Jacobowitz

References:
- RFA: fix minor memory leak in symfile.c
  - From: Tom Tromey
- Re: RFA: fix minor memory leak in symfile.c
  - From: Joel Brobecker
- Re: RFA: fix minor memory leak in symfile.c
  - From: Tom Tromey
- Re: RFA: fix minor memory leak in symfile.c
  - From: Joel Brobecker
- Re: RFA: fix minor memory leak in symfile.c
  - From: Tom Tromey
- Re: RFA: fix minor memory leak in symfile.c
  - From: Thiago Jung Bauermann

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]