This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA record/replay] displaced stepping and record/replay


Committed.

teawater wrote:
Looks good. Please check it in.

Thanks,
Hui

On Mon, Oct 6, 2008 at 05:27, Michael Snyder <msnyder@vmware.com> wrote:
Hui --

I think I may have stumbled on the answer to this whole problem!
One line change -- just don't allow displaced stepping when in
record *or* replay mode.

Michael


2008-10-05 Michael Snyder <msnyder@vmware.com>


       * infrun.c (use_displaced_stepping): Disallow displaced
       stepping if using record/replay target.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.300.2.8
diff -u -p -r1.300.2.8 infrun.c
--- infrun.c    5 Oct 2008 20:00:36 -0000       1.300.2.8
+++ infrun.c    5 Oct 2008 21:23:48 -0000
@@ -645,7 +645,7 @@ use_displaced_stepping (struct gdbarch *
 {
  return (can_use_displaced_stepping
         && gdbarch_displaced_step_copy_insn_p (gdbarch)
-         && !RECORD_IS_REPLAY);
+         && !RECORD_IS_USED);
 }

/* Clean out any stray displaced stepping state. */




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]