This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [reverse RFA] Remove process record warning code
- From: Eli Zaretskii <eliz at gnu dot org>
- To: teawater <teawater at gmail dot com>
- Cc: msnyder at vmware dot com, gdb-patches at sourceware dot org
- Date: Fri, 17 Oct 2008 12:57:41 +0200
- Subject: Re: [reverse RFA] Remove process record warning code
- References: <daef60380810170057l56803830nf79e6d6befa7f3cc@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 17 Oct 2008 15:57:03 +0800
> From: teawater <teawater@gmail.com>
>
> @@ -427,12 +426,8 @@ kill_if_already_running (int from_tty)
> restart it. */
> target_require_runnable ();
>
> - if (from_tty)
> - if (!query (RECORD_IS_USED ?
> - "The program being debugged has been started already,\n\
> -and is running in record/replay mode. Do you want to abandon\n\
> -the recording and start the program from the beginning? " :
> - "The program being debugged has been started already.\n\
> + if (from_tty
> + && !query ("The program being debugged has been started already.\n\
> Start it from the beginning? "))
> error (_("Program not restarted."));
> target_kill ();
Should the string in the call to `query' be in _() ? (Yes, I know you
just copied existing code, but why not fix it while at that?)