This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: regression from print refactoring (was : mi/2549: data-list-register-values igonores the format parameter)
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 14 Nov 2008 14:13:37 +0300
- Subject: Re: RFA: regression from print refactoring (was : mi/2549: data-list-register-values igonores the format parameter)
- References: <20081107201949.23460.qmail@sourceware.org> <m3bpwngghm.fsf@fleche.redhat.com> <m3k5baf0bt.fsf_-_@fleche.redhat.com>
Tom Tromey wrote:
>>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:
>
> Nick> Why not add the tests below? There were three failures before
> Nick> your change and they all pass after it. They're pretty basic,
> Nick> and I don't know if there are any architectures for which they
> Nick> wouldn't work, but they would at least prevent this regression
> Nick> from occurring again.
>
> Here's the complete patch.
>
> Built & regtested on x86-64 (compile farm).
>
> Please review.
This looks fine to me.
Thanks,
Volodya