This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Don't use builtin_long() when ptrdiff_t is needed in gnu-v3-abi.c
- From: Daniel Jacobowitz <drow at false dot org>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 7 Dec 2008 15:14:07 -0500
- Subject: Re: [RFA] Don't use builtin_long() when ptrdiff_t is needed in gnu-v3-abi.c
- References: <20081204212251.30088b54@mesquite.lan>
On Thu, Dec 04, 2008 at 09:22:51PM -0700, Kevin Buettner wrote:
> This patch remedies this situation by using the same ptrdiff_t type
> as that used in the construction of the vtable type.
>
> Okay?
This makes sense to me; thanks for fixing it.
> + /* The "offset_to_top" field has the appropriate (ptrdiff_t) type. */
> + return TYPE_FIELD_TYPE(vtable_type, vtable_field_offset_to_top);
Space before paren, btw.
--
Daniel Jacobowitz
CodeSourcery