This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix completion memory double-free
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 22 Dec 2008 08:35:02 +0400
- Subject: Re: [patch] Fix completion memory double-free
- References: <20081220005103.GA19202@host0.dyn.jankratochvil.net>
> 2008-12-20 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix memory double-free.
> * completer.c (line_completion_function): Clear LIST after called xfree.
Approved.
> gdb/testsuite/
> 2008-12-20 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.base/completion.exp (Completing non-existing component): New test.
And approved.
I really wonder if the "sleep 1" is needed in this case. A 1sec sleeping
delay is a LOT of time :-(, particularly since we can't run more than
one testcase at a time.
Thanks for the fix!
--
Joel