This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ser-mingw.c will be failed to build on GCC4.4.


Hello Joel,
Thanks for your comment.

I reviewed them after I sent mail.
Your idea is reasonable. It shut GCC4.4's warnings up.
The another solustion is to add noreturn attribute, I guess.
Anyway I'll send some patches later.

On 2008/12/24, at 12:33, Joel Brobecker wrote:

>> Some functions in ser-mingw.c is declared with return value, with no
>> return statement.  For example, console_select_thread(),
>> pipe_select_thread(), file_select_thread().
>
> All these functions are used as the initial function when creating
> threads.  According to the MS documentation, the return value is
> used to determine whether the function was successful or not.
> In our case, I think that the thing to do is to add a "return 0"
> at the end.
>
> -- 
> Joel
>

Masaki Muranaka
Monami Software





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]