This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/win32] Wrong use of type DWORD in win32-nat.c


On Wed, Jan 07, 2009 at 03:31:25PM +0400, Joel Brobecker wrote:
>Fix some incorrect uses of type DWORD that cause problems on x86_64-windows
>(compilation warnings and errors due to DWORD and SIZE_T being different
>types).
>
>2009-01-07  Joel Brobecker  <brobecker@adacore.com>
>
>        * win32-nat.c (get_image_name, win32_xfer_memory): Fix type
>        definition of local variable "done".
>        (info_w32_command, handle_exception): Remove unnecessary cast.
>
>Now that I look at the patch again, I wonder if we shouldn't
>print the ExceptionAddress using function host_address_to_string,
>rather than using the %lx format...

Probably.  There are a couple of places where that would need to be
changed.

Ok to apply.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]