This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] fix build breakage on arm-none-eabi
- From: Nathan Froyd <froydnj at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 8 Jan 2009 10:21:26 -0800
- Subject: [PATCH] fix build breakage on arm-none-eabi
This patch:
http://sourceware.org/ml/gdb-patches/2009-01/msg00063.html
breaks compilation on arm-none-eabi:
/scratch/froydnj/fsf/armeabi/obj/gdb-src-mainline-0-arm-none-eabi-i686-pc-linux-gnu/gdb/remote-sim.c: In function `init_callbacks':
/scratch/froydnj/fsf/armeabi/obj/gdb-src-mainline-0-arm-none-eabi-i686-pc-linux-gnu/gdb/remote-sim.c:169: warning: assignment makes qualified function pointer from unqualified
The patch below fixes compilation. sim/common/callback.c calls exit, so
I figured it was fair to make gdb_os_error call exit as well.
OK to commit?
-Nathan
2009-01-08 Nathan Froyd <froydnj@codesourcery.com>
* remote-sim.c (gdb_os_error): Mark as a noreturn function.
Call exit to make it obvious to GCC.
Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.81
diff -u -u -r1.81 remote-sim.c
--- remote-sim.c 3 Jan 2009 05:57:53 -0000 1.81
+++ remote-sim.c 8 Jan 2009 18:20:26 -0000
@@ -70,7 +70,11 @@
static void gdb_os_evprintf_filtered (host_callback *, const char *, va_list);
-static void gdb_os_error (host_callback *, const char *, ...);
+static void gdb_os_error (host_callback *, const char *, ...)
+#ifdef __GNUC__
+ __attribute__ ((__noreturn__))
+#endif
+ ;
static void gdbsim_fetch_register (struct regcache *regcache, int regno);
@@ -273,6 +277,7 @@
verror (format, args);
va_end (args);
}
+ exit (1);
}
int