This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/RFA] -break-insert -d
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Pedro Alves <pedro at codesourcery dot com>, Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org, gdb-patches at sources dot redhat dot com, Nick Roberts <nickrob at snap dot net dot nz>, Marc Khouzam <marc dot khouzam at ericsson dot com>
- Date: Fri, 30 Jan 2009 19:25:28 +0300
- Subject: Re: [RFC/RFA] -break-insert -d
- References: <200901261614.25050.vladimir@codesourcery.com> <200901261751.38003.pedro@codesourcery.com>
On Monday 26 January 2009 20:51:37 Pedro Alves wrote:
> On Monday 26 January 2009 13:14:24, Vladimir Prus wrote:
> >
> > Presently, the -break-insert command always creates enabled breakpoint. Marc has noticed
> > that in Eclipse, with non-stop mode, this case lead to races. Specifically, if a breakpoint
> > is disabled in UI, then Eclipse first inserts a breakpoint, and then makes it disabled. So,
> > there's a window when the breakpoint is inserted in the target. One possible solution is
> > to modify Eclipse to never insert disabled breakpoint in GDB. However, this special-casing
> > has to be done in every frontend, and GDB-side solution is better. The below patch implements
> > new -d option to the -break-insert command, which causes the newly created breakpoints to be
> > disabled.
> >
> > Is the breakpoint.c change OK.
>
> Looks fine to me.
Thanks. Eli, any comments on the doc bit?
Thanks,
Volodya