Re: [RFA][python] Fixes for existing Python code.

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:

Thiago> I'd also like to remind that the following patches for Python support
Thiago> are still pending:

Thiago> http://sourceware.org/ml/gdb-patches/2009-01/msg00016.html

This one is the patch to add more methods to Value.  I have two
comments on it.

First, in convert_value_from_python, I see:

-	return NULL;
+	{
+	  PyErr_Clear ();
+	  error (_("Error converting Python value."));
+	}
 
This should call gdbpy_print_stack instead of PyErr_Clear.  I think we
have -- or should have -- a general rule that we call
gdbpy_print_stack when "converting" a Python exception to a gdb
exception.  Using this lets the user control whether stack traces are
printed for Python errors, which is handy for debugging Python code.

My other comment is just to make sure that all of Eli's documentation
comments have been addressed.

The patch is ok with the above change.

Thiago> http://sourceware.org/ml/gdb-patches/2009-01/msg00003.html

This is the patch to add la_getstr.
I'll reply to it separately.

Thiago> http://sourceware.org/ml/gdb-patches/2009-01/msg00004.html

This adds Value.string, using la_getstr.

This patch is ok once the la_getstr code goes in, and provided that
Eli oks the documentation.

Tom