This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Document fallback behavior for target_so_ops same.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 3 Feb 2009 08:36:27 -0800
- Subject: Re: [RFA] Document fallback behavior for target_so_ops same.
- References: <23511769-09D5-4558-A38F-B6ECC376C2FA@adacore.com>
> 2009-02-03 Tristan Gingold <gingold@adacore.com>
>
> * solist.h (struct target_so_ops): Comment fallback behavior for
> operation same.
Thanks for sending the patch. This is OK, with just one tiny request:
> diff -u -r1.23 solist.h
> --- solist.h 15 Jan 2009 16:35:22 -0000 1.23
> +++ solist.h 3 Feb 2009 12:51:17 -0000
> @@ -119,7 +119,8 @@
>
> /* Given two so_list objects, one from the GDB thread list
> and another from the list returned by current_sos, return 1
> - if they represent the same library. */
> + if they represent the same library.
> + Falls back to using strcmp on so_original_name field. */
Can you add "when set to NULL" at the end of your new sentence?
Falls back to using strcmp on so_original_name field
when set to NULL.
Thanks,
--
Joel