This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [1/2] Inspect extra signal information


> From: Pedro Alves <pedro@codesourcery.com>
> Date: Thu, 5 Feb 2009 01:14:04 +0000
> 
> Here's a proper patch.
> 
> Does it look OK?

Yes, but I have a couple of nits:

> +A value is in addition descriminated by its lvalue-ness, given its
                          ^^^^^^^^^^^^^
"discriminated"

> +Represents part of a gdb internal variable.  E.g., a structure field.
                        ^^^
@value{GDBN}

> +objects for specific purposes, all abstracted way from the the core
                                                 ^^^      ^^^^^^^
"way" or "away"?  Also, lose the extra "the".

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]