This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MI solib notification
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Tom Tromey <tromey at redhat dot com>, Marc Khouzam <marc dot khouzam at ericsson dot com>, gdb-patches at sources dot redhat dot com, Nick Roberts <nickrob at snap dot net dot nz>
- Date: Tue, 17 Feb 2009 22:08:00 +0300
- Subject: Re: MI solib notification
- References: <200901310010.46738.vladimir@codesourcery.com> <200902122311.05275.vladimir@codesourcery.com> <20090212201744.GA32437@caradoc.them.org>
On Thursday 12 February 2009 23:17:44 Daniel Jacobowitz wrote:
> On Thu, Feb 12, 2009 at 11:11:04PM +0300, Vladimir Prus wrote:
> > Can you write down the comment that disable_breakpoints_in_unloaded_shlib
> > would have to contain to explain all this? ;-) I assume it will go like this:
> >
> > Don't emit any message here for a.out, because for all the other
> > targets some other code calls some other function that arranges for
> > this message to not be printed when rerunning the program...
> >
> > In other words, the problem with checking for a.out is that it deeply depends on
> > intricate details of some other code.
>
> It's not about the message, but about the disabling. I mean:
>
> /* SunOS a.out shared libraries are always mapped, so do not
> disable breakpoints; they will only be reported as unloaded
> through clear_solib when GDB discards its shared library
> list. See clear_solib for more information. */
For avoidance of doubt, is the attached OK code-wize?
- Volodya
commit 266230fb5ea8f192ec5725d23716ff2949a13ce0
Author: Vladimir Prus <vladimir@codesourcery.com>
Date: Fri Jan 30 20:50:50 2009 +0300
Implement MI notification for library loading/unloading
gdb/doc/
* gdb.texinfo (GDB/MI Async Records): Document the
=library-loaded and =library-unloaded notifications.
gdb/
* mi/mi-interp.c (mi_solib_loaded, mi_solib_unloaded): New.
(mi_interpreter_init): Register the above.
* solib.c (clear_solib): Notify solib unload.
* breakpoint.c (disable_breakpoints_in_unloaded_shlib): Do not
disable breakpoints on a.out targets.
gdb/testsuite/
* gdb.mi/mi-nonstop.exp (notifs): Adjust for library notifications.
* gdb.mi/mi-nsintrall.exp (notifs): Likewise.
* gdb.mi/mi-nsmoribund.exp (notifs): Likewise.
* lib/mi-support.exp (library_loaded_re): New.
(mi_run_cmd, mi_send_resuming_command_raw): Adjust.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 0caedec..9b48f24 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -4457,6 +4457,13 @@ disable_breakpoints_in_unloaded_shlib (struct so_list *solib)
struct bp_location *loc;
int disabled_shlib_breaks = 0;
+ /* We should not disable breakpoints on a.out targets.
+ See comment on solib.c:clear_solib for a detailed
+ explanation. */
+ if (exec_bfd != NULL
+ && bfd_get_flavour (exec_bfd) != bfd_target_aout_flavour)
+ return;
+
ALL_BP_LOCATIONS (loc)
{
struct breakpoint *b = loc->owner;
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 6aad520..805b834 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -19912,6 +19912,15 @@ We suggest that in response to this notification, front ends
highlight the selected thread and cause subsequent commands to apply to
that thread.
+@item =library-loaded,id="@var{id}",target-name="@var{target-name}",host-name="@var{host-name}",low-address="@var{low}",high-address="@var{high}",symbols-loaded="@var{loaded}"
+Reports that a new library file was loaded by the program. The
+@var{id} field is an opaque identifier of the library. For remote
+debugging case, @var{target-name} and @var{host-name} fields give the
+name of the library file on the target, and on the host respectively.
+
+@item =library-unloaded,id="@var{id}",target-name="@var{target-name}",host-name="@var{host-name}"
+Reports that a library was loaded by the program.
+
@end table
@node GDB/MI Frame Information
diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c
index 95dfdf4..d32638c 100644
--- a/gdb/mi/mi-interp.c
+++ b/gdb/mi/mi-interp.c
@@ -34,6 +34,7 @@
#include "mi-common.h"
#include "observer.h"
#include "gdbthread.h"
+#include "solist.h"
/* These are the interpreter setup, etc. functions for the MI interpreter */
static void mi_execute_command_wrapper (char *cmd);
@@ -58,6 +59,8 @@ static void mi_thread_exit (struct thread_info *t);
static void mi_new_inferior (int pid);
static void mi_inferior_exit (int pid);
static void mi_on_resume (ptid_t ptid);
+static void mi_solib_loaded (struct so_list *solib);
+static void mi_solib_unloaded (struct so_list *solib);
static void *
mi_interpreter_init (int top_level)
@@ -86,6 +89,8 @@ mi_interpreter_init (int top_level)
observer_attach_inferior_exit (mi_inferior_exit);
observer_attach_normal_stop (mi_on_normal_stop);
observer_attach_target_resumed (mi_on_resume);
+ observer_attach_solib_loaded (mi_solib_loaded);
+ observer_attach_solib_unloaded (mi_solib_unloaded);
}
return mi;
@@ -408,6 +413,31 @@ mi_on_resume (ptid_t ptid)
gdb_flush (raw_stdout);
}
+static void mi_solib_loaded (struct so_list *solib)
+{
+ struct mi_interp *mi = top_level_interpreter_data ();
+ target_terminal_ours ();
+ fprintf_unfiltered (mi->event_channel,
+ "library-loaded,id=\"%s\",target-name=\"%s\",host-name=\"%s\",low-address=\"0x%s\",high-address=\"0x%s\",symbols-loaded=\"%d\"",
+ solib->so_original_name, solib->so_original_name,
+ solib->so_name,
+ paddr (solib->addr_low), paddr (solib->addr_high),
+ solib->symbols_loaded);
+ gdb_flush (mi->event_channel);
+}
+
+static void mi_solib_unloaded (struct so_list *solib)
+{
+ struct mi_interp *mi = top_level_interpreter_data ();
+ target_terminal_ours ();
+ fprintf_unfiltered (mi->event_channel,
+ "library-unloaded,id=\"%s\",target-name=\"%s\",host-name=\"%s\"",
+ solib->so_original_name, solib->so_original_name,
+ solib->so_name);
+ gdb_flush (mi->event_channel);
+}
+
+
extern initialize_file_ftype _initialize_mi_interp; /* -Wmissing-prototypes */
void
diff --git a/gdb/solib.c b/gdb/solib.c
index cce4f7f..5a28292 100644
--- a/gdb/solib.c
+++ b/gdb/solib.c
@@ -908,6 +908,7 @@ clear_solib (void)
{
struct so_list *so = so_list_head;
so_list_head = so->next;
+ observer_notify_solib_unloaded (so);
if (so->abfd)
remove_target_sections (so->abfd);
free_so (so);
diff --git a/gdb/testsuite/gdb.mi/mi-nonstop.exp b/gdb/testsuite/gdb.mi/mi-nonstop.exp
index 2521ae5..08952b0 100644
--- a/gdb/testsuite/gdb.mi/mi-nonstop.exp
+++ b/gdb/testsuite/gdb.mi/mi-nonstop.exp
@@ -63,7 +63,7 @@ mi_gdb_test "200-break-insert -t main" ".*"
set created "=thread-created,id=\"$decimal\"\r\n"
set running "\\*running,thread-id=\"$decimal\"\r\n"
-set notifs "($created)*($running)*"
+set notifs "($created)*($running)*($library_loaded_re)*"
# Note: presently, we skip this test on non-native targets,
# so 'run' is OK. As soon as we start to run this on remote
diff --git a/gdb/testsuite/gdb.mi/mi-nsintrall.exp b/gdb/testsuite/gdb.mi/mi-nsintrall.exp
index b0d7b71..d34b08d 100644
--- a/gdb/testsuite/gdb.mi/mi-nsintrall.exp
+++ b/gdb/testsuite/gdb.mi/mi-nsintrall.exp
@@ -62,7 +62,7 @@ mi_gdb_test "200-break-insert -t main" ".*"
set created "=thread-created,id=\"$decimal\"\r\n"
set running "\\*running,thread-id=\"$decimal\"\r\n"
-set notifs "($created)*($running)*"
+set notifs "($created)*($running)*($library_loaded_re)*"
# Note: presently, we skip this test on non-native targets,
# so 'run' is OK. As soon as we start to run this on remote
diff --git a/gdb/testsuite/gdb.mi/mi-nsmoribund.exp b/gdb/testsuite/gdb.mi/mi-nsmoribund.exp
index b836c5b..505fc84 100644
--- a/gdb/testsuite/gdb.mi/mi-nsmoribund.exp
+++ b/gdb/testsuite/gdb.mi/mi-nsmoribund.exp
@@ -62,7 +62,7 @@ mi_gdb_test "200-break-insert -t main" ".*"
set created "=thread-created,id=\"$decimal\"\r\n"
set running "\\*running,thread-id=\"$decimal\"\r\n"
-set notifs "($created)*($running)*"
+set notifs "($created)*($running)*($library_loaded_re)*"
# Note: presently, we skip this test on non-native targets,
# so 'run' is OK. As soon as we start to run this on remote
diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
index a2aa629..f62c240 100644
--- a/gdb/testsuite/lib/mi-support.exp
+++ b/gdb/testsuite/lib/mi-support.exp
@@ -31,6 +31,7 @@ global mi_inferior_tty_name
set MIFLAGS "-i=mi"
set thread_selected_re "=thread-selected,id=\"\[0-9+\]\"\r\n"
+set library_loaded_re "=library-loaded\[^\n\]+\"\r\n"
#
# mi_gdb_exit -- exit the GDB, killing the target program if necessary
@@ -778,6 +779,7 @@ proc mi_run_cmd {args} {
}
global mi_gdb_prompt
global thread_selected_re
+ global library_loaded_re
if [target_info exists gdb_init_command] {
send_gdb "[target_info gdb_init_command]\n";
@@ -819,7 +821,7 @@ proc mi_run_cmd {args} {
send_gdb "220-exec-run $args\n"
gdb_expect {
- -re "220\\^running\r\n(\\*running,thread-id=\"\[^\"\]+\"\r\n|=thread-created,id=\"1\",group-id=\"\[0-9\]+\"\r\n)*(${thread_selected_re})?${mi_gdb_prompt}" {
+ -re "220\\^running\r\n(\\*running,thread-id=\"\[^\"\]+\"\r\n|=thread-created,id=\"1\",group-id=\"\[0-9\]+\"\r\n)*(${library_loaded_re})*(${thread_selected_re})?${mi_gdb_prompt}" {
}
timeout {
perror "Unable to start target"
@@ -1435,10 +1437,11 @@ proc mi_send_resuming_command_raw {command test} {
global mi_gdb_prompt
global thread_selected_re
+ global library_loaded_re
send_gdb "$command\n"
gdb_expect {
- -re "\\^running\r\n\\*running,thread-id=\"\[^\"\]+\"\r\n($thread_selected_re)?${mi_gdb_prompt}" {
+ -re "\\^running\r\n\\*running,thread-id=\"\[^\"\]+\"\r\n($library_loaded_re)*($thread_selected_re)?${mi_gdb_prompt}" {
# Note that lack of 'pass' call here -- this works around limitation
# in DejaGNU xfail mechanism. mi-until.exp has this:
#