This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Add _() to query

From: teawater <teawater at gmail dot com>
To: Eli Zaretskii <eliz at gnu dot org>
Cc: gdb-patches at sourceware dot org
Date: Wed, 25 Feb 2009 10:15:41 +0800
Subject: Re: [RFA] Add _() to query
References: <daef60380902232310n32eb1f22m71265f0a38a952b1@mail.gmail.com> <ud4d7r7l7.fsf@gnu.org>

On Wed, Feb 25, 2009 at 02:52, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Tue, 24 Feb 2009 15:10:51 +0800
>> From: teawater <teawater@gmail.com>
>>
>> Hi Eli,
>>
>> I remember you told me that you want to add _() to all query.
>> I make a patch for it. Do you think it's OK?
>
> Yes, with the exception of a single comment below.
>
> (I don't have an opinion regarding the _() vs --keyword approach to
> marking translatable strings.)
>
>> - ?if (from_tty && (!query ("%s", "")))
>> + ?if (from_tty && (!query (_("%s"), "")))
>
> AFAIK, it is absolutely pointless to mark for translation strings that
> have no text, just formatted output conversion spec. ?That's because
> the only translation of such strings is the string itself.
>
Thanks Eli, I have removed this line and checked patch in.

Hui

References:
- [RFA] Add _() to query
  - From: teawater
- Re: [RFA] Add _() to query
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]