This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Correct `gcc -D' macros get ignored (PR 9873)

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 9 Mar 2009 19:55:48 +0100
Subject: Re: [patch] Correct `gcc -D' macros get ignored (PR 9873)
References: <20090219214540.GA32244@host0.dyn.jankratochvil.net> <20090228071514.GA25299@adacore.com> <20090228100225.GA15788@host0.dyn.jankratochvil.net> <20090303005430.GL26056@adacore.com> <20090309005707.GB29150@host0.dyn.jankratochvil.net> <20090309184138.GB4561@adacore.com>

On Mon, 09 Mar 2009 19:41:38 +0100, Joel Brobecker wrote:
> > Sure I find your text better although its first line does not follow the GNU
> > Coding Style directive `[...] please write complete sentences [...]'.
> > Used your text.
> 
> Are you refering to the "First pass:"? I think it's OK.

Yes; OK.


Checked-in: http://sourceware.org/ml/gdb-cvs/2009-03/msg00041.html

A testcase (to verify it still works wrt current gcc) is left for review in:
[patch] Better display command-line macros + doc addon
http://sourceware.org/ml/gdb-patches/2009-03/msg00104.html


Thanks for the review,
Jan

References:
- Re: [patch] Correct `gcc -D' macros get ignored (PR 9873)
  - From: Joel Brobecker
- Re: [patch] Correct `gcc -D' macros get ignored (PR 9873)
  - From: Jan Kratochvil
- Re: [patch] Correct `gcc -D' macros get ignored (PR 9873)
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]