This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Fix build failure on AIX (missing target_ops params)
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 12 Mar 2009 10:47:12 -0700
- Subject: [commit] Fix build failure on AIX (missing target_ops params)
Hello,
This patch allows us to build GDB again on AIX. This allowed me to
notice that the aix-thread.c file could use a little modernization
(getting rid of the 'base_target' global), but I'll leave that for later.
While working on this file, I decided to add Ada task switch support,
since it only required the addition of a tiny function.
2009-03-12 Joel Brobecker <brobecker@adacore.com>
Fix a build failure on AIX introduced after a change in the profile
of some of the "methods" in the target_ops structure.
* aix-thread.c: Add missing target_ops parameter throughout.
Implement Ada task switching on AIX.
* aix-thread.c (aix_thread_get_ada_task_ptid): New function.
(init_aix_thread_ops): Set aix_thread_ops.to_get_ada_task_ptid.
Checked in.
--
Joel
Index: aix-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/aix-thread.c,v
retrieving revision 1.60
diff -u -p -r1.60 aix-thread.c
--- aix-thread.c 6 Feb 2009 22:21:26 -0000 1.60
+++ aix-thread.c 12 Mar 2009 17:44:05 -0000
@@ -958,7 +958,8 @@ aix_thread_detach (struct target_ops *op
and all threads otherwise. */
static void
-aix_thread_resume (ptid_t ptid, int step, enum target_signal sig)
+aix_thread_resume (struct target_ops *ops,
+ ptid_t ptid, int step, enum target_signal sig)
{
struct thread_info *thread;
pthdb_tid_t tid[2];
@@ -967,7 +968,7 @@ aix_thread_resume (ptid_t ptid, int step
{
struct cleanup *cleanup = save_inferior_ptid ();
inferior_ptid = pid_to_ptid (PIDGET (inferior_ptid));
- base_target.to_resume (ptid, step, sig);
+ base_target.to_resume (ops, ptid, step, sig);
do_cleanups (cleanup);
}
else
@@ -1276,13 +1277,14 @@ fetch_regs_kernel_thread (struct regcach
thread/process specified by inferior_ptid. */
static void
-aix_thread_fetch_registers (struct regcache *regcache, int regno)
+aix_thread_fetch_registers (struct target_ops *ops,
+ struct regcache *regcache, int regno)
{
struct thread_info *thread;
pthdb_tid_t tid;
if (!PD_TID (inferior_ptid))
- base_target.to_fetch_registers (regcache, regno);
+ base_target.to_fetch_registers (ops, regcache, regno);
else
{
thread = find_thread_pid (inferior_ptid);
@@ -1615,13 +1617,14 @@ store_regs_kernel_thread (const struct r
thread/process specified by inferior_ptid. */
static void
-aix_thread_store_registers (struct regcache *regcache, int regno)
+aix_thread_store_registers (struct target_ops *ops,
+ struct regcache *regcache, int regno)
{
struct thread_info *thread;
pthdb_tid_t tid;
if (!PD_TID (inferior_ptid))
- base_target.to_store_registers (regcache, regno);
+ base_target.to_store_registers (ops, regcache, regno);
else
{
thread = find_thread_pid (inferior_ptid);
@@ -1678,10 +1681,10 @@ aix_thread_mourn_inferior (struct target
/* Return whether thread PID is still valid. */
static int
-aix_thread_thread_alive (ptid_t ptid)
+aix_thread_thread_alive (struct target_ops *ops, ptid_t ptid)
{
if (!PD_TID (ptid))
- return base_target.to_thread_alive (ptid);
+ return base_target.to_thread_alive (ops, ptid);
/* We update the thread list every time the child stops, so all
valid threads should be in the thread list. */
@@ -1768,6 +1771,12 @@ aix_thread_extra_thread_info (struct thr
return ret;
}
+static ptid_t
+aix_thread_get_ada_task_ptid (long lwp, long thread)
+{
+ return ptid_build (ptid_get_pid (inferior_ptid), 0, thread);
+}
+
/* Initialize target aix_thread_ops. */
static void
@@ -1791,6 +1800,7 @@ init_aix_thread_ops (void)
aix_thread_ops.to_thread_alive = aix_thread_thread_alive;
aix_thread_ops.to_pid_to_str = aix_thread_pid_to_str;
aix_thread_ops.to_extra_thread_info = aix_thread_extra_thread_info;
+ aix_thread_ops.to_get_ada_task_ptid = aix_thread_get_ada_task_ptid;
aix_thread_ops.to_stratum = thread_stratum;
aix_thread_ops.to_magic = OPS_MAGIC;
}