This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch] Improve path lookup of absolute source file
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Francois Rigault <francois dot rigault at amadeus dot com>
- Cc: Daniel Jacobowitz <drow at false dot org>, Thiago Jung Bauermann <thiago dot bauermann at gmail dot com>, gdb-patches at sourceware dot org
- Date: Sun, 15 Mar 2009 12:30:05 -0700
- Subject: Re: [Patch] Improve path lookup of absolute source file
- References: <OFD9AE0868.9D61C83E-ONC1257576.002EC255-C1257576.002EE478@amadeus.com>
> would you accept a patch that uses a macro somewhere so that users can
> choose to compile gdb with or without the modified lookup routine ?
Not sure what the other maintainers think, but for the type of change
that you're suggestion, we generally don't. This tends to complicate
the code, and can also confuse uses as to why the same version of GDB
would "work" in one case and "not work" in the other. There's also
the question of testing if your change is disabled by default.
A softer approach would be based on using a "set ..." command to
determine one approach or the other. But I am not sure it would make
sense in this case, as my understanding is that the setting would
allow the user to switch between two approaches that are similar,
but with different holes in them.
--
Joel