This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Eli, I had make the patches for code and doc. Please help me review it. Thanks, Hui On Fri, Mar 13, 2009 at 17:45, Eli Zaretskii <eliz@gnu.org> wrote: >> Date: Fri, 13 Mar 2009 07:55:59 +0800 >> From: teawater <teawater@gmail.com> >> Cc: Pedro Alves <pedro@codesourcery.com>, Daniel Jacobowitz <drow@false.org>, >> ? ? ? "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> >> >> + ?add_setshow_enum_cmd ("disassemble-next-line", class_run, >> + ? ? ? ? ? ? ? ? ? ? disassemble_next_line_enum, >> + ? ? ? ? ? ? ? ? ? ? &disassemble_next_line, _("\ >> +Set debugger's willingness to use disassemble-next-line."), _("\ >> +Show debugger's willingness to use disassemble-next-line."), _("\ > > This self-referential doc string is confusing. ?I suggest to change to > something like this: > > ?Set whether to disassemble next source line when execution stops. > > and similarly for Show. > >> +If ON, GDB will disassemble the next source line when execution\n\ >> +stops.\n\ > > ?If ON, GDB will display disassembly of the next source line when\n\ > ?execution of the program being debugged stops.\n\ > >> +If AUTO (which is the default) or the next source line cannot be\n\ >> +ascertained, the next instruction will be disassembled instead."), > > What does it mean ``the next source line cannot be ascertained''? > > In any case, instead of ``the next instruction will be disassembled > instead'', I suggest ``display disassembly of the next instruction > instead.'' >
Attachment:
disassemble-next-line.txt
Description: Text document
Attachment:
disassemble-next-line-doc.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |