This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [3/3] broken -thread-info output in non-stop mode, fix it


On Tuesday 17 March 2009 09:23:58 Pedro Alves wrote:
> This fixes the broken -thread-info output mentioned in this thread:
>
>  http://sourceware.org/ml/gdb-patches/2009-03/msg00236.html
>
> ... as suggested by Vladimir, the patch makes us output ^running
> only if the target was proceeded.  I've added a new observer
> (about_to_proceed), and implemented Vladimir's suggestion on top of
> it.  There's this `breakpoint_proceeded' global that is used
> by the breakpoint.c module for something very similar, so I've
> moved that global into breakpoint.c, and made it static, and then
> used the same observer to set it.  Since breakpoint_proceeded is
> not global anymore, we can't save/restore it when doing infcalls
> from infrun.c.  What I've done instead, was to make the
> about_to_proceed observer in breakpoint.c not set breakpoint_proceeded if
> we're about to do an inferior function call.  And we know we're doing
> an infcall due to this new thread_info->in_infcall flag added by the
> previous patch.
>
> Vladimir, does this look like what you were picturing?

Yes, this looks very nice, thank you.

- Volodya


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]