This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] python API exposing inferior's frame stack.


> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: gdb-patches@sourceware.org
> Date: Fri, 20 Mar 2009 19:15:20 -0300
> 
> So I am changing the documentation and doc strings for Frame.older and
> Frame.newer to use similar wording:
> 
> +@defmethod Frame older
> +Return the frame that called this frame.
> +@end defmethod
> +
> +@defmethod Frame newer
> +Return the frame called by this frame.
> +@end defmethod
> 
> I also changed Frame.unwind_stop_reason to use "outermost":
> 
> +@defmethod Frame unwind_stop_reason
> +Return an integer representing the reason why it's not possible to find
> +more frames toward the outermost frame.  Use
> +@code{gdb.frame_stop_reason_string} to convert the value returned by this
> +function to a string.
> +@end defmethod
> 
> What do you think?

That's fine, thanks.

One comment:

> +@defmethod Frame equals frame
> +Compare frames.
> +@end defmethod

I see from the code that this return a boolean yes/no value (as
opposed to also providing some idea about the order, like strcmp in
C).  So perhaps "compare frames" might mislead someone.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]