This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/win32] Improve C-c handling when process in different console
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: Nicolas Roche <roche at adacore dot com>, gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>
- Date: Sun, 22 Mar 2009 17:54:14 -0400
- Subject: Re: [RFA/win32] Improve C-c handling when process in different console
- References: <20081002225504.GF26384@adacore.com> <20090316214356.GB384@adacore.com>
On Mon, Mar 16, 2009 at 05:43:56PM -0400, Joel Brobecker wrote:
>> 2008-10-02 Nicolas Roche <roche@adacore.com>
>>
>> * win32-nat.c (check_for_DebugBreakProcess): New function.
>> (ctrl_c_handler): New function.
>> (win32_wait): Register ctrl_c_handler as Ctrl-C handler if the inferior
>> is run in a separate console.
>> (_initialize_win32_nat): Check for DebugBreakProcess in kernel32.dll.
>
>Here is a new version of the patch. I had to change a couple of things:
>
> 1. Remove the WINBASEAPI when declaring kernel32_DebugBreakProcess;
> My understanding is that this attribute doesn't make sense at all
> for a static variable.
>
> 2. Cast the result of GetProcAddress to "void *" in order to avoid
> a compiler warning. This is consistent with what we do in the other
> GetProcAddress calls.
>
>This patch has been working very well for us over the past year.
>Do you think you could take a look to see if we can have something in
>before we roll 7.0 out?
I've finally checked in some of (but not all of) the changes that I
wanted to make for dynamically loading functions in windows-nat.c. That
reduces the size of this patch, which I've now checked in.
cgf