This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Add task-specific breakpoint capability...


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Humpf. Forgot the new patch.

I blame your MUA :)

Joel> +int
Joel> +breakpoint_ada_task_match (CORE_ADDR pc, ptid_t ptid)
Joel> +{
Joel> +  struct bp_location *bpt;
Joel> +  int taskid = ada_get_task_number (ptid);
Joel> +
Joel> +  ALL_BP_LOCATIONS (bpt)
[...]

Joel> -	  if (!breakpoint_thread_match (stop_pc, ecs->ptid))
Joel> +	  if (!breakpoint_thread_match (stop_pc, ecs->ptid)
Joel> +	      || !breakpoint_ada_task_match (stop_pc, ecs->ptid))
Joel>  	    thread_hop_needed = 1;

It seems like it would be more efficient to combine
breakpoint_thread_match and breakpoint_ada_task_match, so we only
have a single loop over all breakpoint locations.
This is probably not very important.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]