This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/commit] Minor cleanup in breakpoint_thread_match


On Wednesday 25 March 2009 18:00:33, Joel Brobecker wrote:
> > 2009-03-25  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * breakpoint.c (breakpoint_thread_match): Split a large condition
> >         into several smaller conditions.  No behavior change.
> > 
> > Tested on x86_64-linux. I made this change in a pretty procedural and
> > mechanical way.  But a second pair of eyes would be appreciated. Plus,
> > I'd like to know if others also prefer splitting this condition like
> > I did.
> 
> Actually, upon rewriting the Ada patch, it occured to me that the
> following is even more helpful in inserting support for task-specific
> breakpoints... I'm currently testing the attached patch.
> 

Looks sane to me.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]