This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] [5/5] Types reference counting [value_history_cleanup]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 11 Apr 2009 12:22:37 +0200
- Subject: [patch] [5/5] Types reference counting [value_history_cleanup]
Hi,
this patch brings no new functionality. It could be enabled only during some
--enable-debug builds but there is currently no such configure option.
Found it caught some bugs during the development (by trying to double-free some
types). It can be also used to verify there are no types leaks.
Thanks,
Jan
gdb/
2009-04-11 Jan Kratochvil <jan.kratochvil@redhat.com>
* value.c (value_history_cleanup): New function.
(_initialize_values): Setup a value_history_cleanup final call.
diff --git a/gdb/value.c b/gdb/value.c
index 9c08a41..12a5662 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -852,6 +852,25 @@ show_values (char *num_exp, int from_tty)
num_exp[1] = '\0';
}
}
+
+/* Sanity check for memory leaks and proper types reference counting. */
+
+static void
+value_history_cleanup (void *unused)
+{
+ while (value_history_chain)
+ {
+ struct value_history_chunk *chunk = value_history_chain;
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE (chunk->values); i++)
+ value_free (chunk->values[i]);
+
+ value_history_chain = chunk->next;
+ xfree (chunk);
+ }
+ value_history_count = 0;
+}
/* Internal variables. These are variables within the debugger
that hold values assigned by debugger commands.
@@ -2049,4 +2068,6 @@ Placeholder command for showing help on convenience functions."),
TYPE_CODE (internal_fn_type) = TYPE_CODE_INTERNAL_FUNCTION;
TYPE_LENGTH (internal_fn_type) = sizeof (struct internal_function *);
TYPE_NAME (internal_fn_type) = "<internal function>";
+
+ make_final_cleanup (value_history_cleanup, NULL);
}