This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA]: Handle multi-line versions of multi-breakpoints
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com (Doug Evans)
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 23 Apr 2009 16:47:34 -0600
- Subject: Re: [RFA]: Handle multi-line versions of multi-breakpoints
- References: <20090302065301.356261C7A1E@localhost>
- Reply-to: tromey at redhat dot com
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> "multi-breakpoints" (multiple breakpoints for the same source
Doug> line) don't work for constructors and inline functions where the
Doug> source expression spans several lines (at least for the new
Doug> testcases included in this patch).
Doug> This patch fixes it by, if there's no exact match,
Doug> rescanning the symtabs for all matches of the best match.
This sounds like Jerome's patch, which I approved earlier today. I
didn't realize that you had both fixed the same problem before doing
that.
After reading both patches, I would prefer for his to go in; assuming
of course that it actually does fix your problem as well.
Your test cases seem more comprehensive. I would not mind seeing
these go in after his patch. They are ok, if you want to do that.
Tom