This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [Patch] [MI] Out-of-scope varObjects no longer trigger a var-update change
- From: "Marc Khouzam" <marc dot khouzam at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Thu, 7 May 2009 15:27:59 -0400
- Subject: RE: [Patch] [MI] Out-of-scope varObjects no longer trigger a var-update change
- References: <6D19CA8D71C89C43A057926FE0D4ADAA0759C401@ecamlmw720.eamcs.ericsson.se>
Ping?
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Marc Khouzam
> Sent: Tuesday, April 28, 2009 4:03 PM
> To: gdb-patches@sourceware.org
> Subject: [Patch] [MI] Out-of-scope varObjects no longer
> trigger a var-update change
>
> Hi,
>
> I believe a small bug slipped in the refactoring of varobj_update
> interface from:
> http://sourceware.org/ml/gdb-patches/2008-05/msg00106.html
>
> From what I see, varobj that are not in scope don't get flagged
> as changed, because nothing was being pushed on the result vector.
> The attached patch fixes this.
>
> The MI part of the testsuite passed ok.
> I have an test to trigger the bug, if you care to see it.
>
> Ok?
>
> 2009-04-28 Marc Khouzam <marc.khouzam@ericsson.com>
>
> * varobj.c (varobj_update): Push an out-of-scope
> variable object on the result vector.
>
> Index: gdb/varobj.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/varobj.c,v
> retrieving revision 1.126
> diff -u -r1.126 varobj.c
> --- gdb/varobj.c 10 Apr 2009 16:00:49 -0000 1.126
> +++ gdb/varobj.c 28 Apr 2009 19:49:24 -0000
> @@ -1188,7 +1188,7 @@
> if (new == NULL)
> r.status = VAROBJ_NOT_IN_SCOPE;
>
> - if (r.type_changed || r.changed)
> + if (r.type_changed || r.changed || r.status ==
> VAROBJ_NOT_IN_SCOPE)
> VEC_safe_push (varobj_update_result, result, &r);
>
> if (r.status == VAROBJ_NOT_IN_SCOPE)
>