This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Trailing spaces in solaris_pid_to_str
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 12 May 2009 11:19:45 +0200
- Subject: Re: [RFC] Trailing spaces in solaris_pid_to_str
- References: <20090501213218.4488B84890@localhost>
> Doesn't matter to me whether to check this in or not,
> just thought I'd pass it on. It is odd. Is there another reason
> for these spaces that I'm missing?
Can't figure it out. I did a bit of archeology, and this pre-dates
the public CVS.
> 2009-05-01 Doug Evans <dje@google.com>
>
> * sol-thread.c (solaris_pid_to_str): Remove trailing spaces in result.
I'm not objecting, but if it's just a visual annoyance and no one else
provides feedback, then perhaps it's better to leave things as is
(taste varies from person to person). If you need that function
elsewhere and it's causing trouble, on the other hand...
> [The spaces in "LWP %ld" are to line up the text with "Thread %ld".
> They don't bother me as much as the trailing spaces so I left them in,
> but they could just as well be deleted.]
If you do remove the trailing spaces, might as well remove the leading
ones too. There're there for formatting, so if we remove the formatting,
we might as well remove all of it (IMO).
--
Joel