This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Wed, 13 May 2009 11:39:27 +0200
- Subject: Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs.
- References: <20090420232900.2456B19C4F6@localhost> <m3y6tu24ty.fsf@fleche.redhat.com> <8ac60eac0904291411o4666b3eha30d95cc88811dd5@mail.gmail.com> <20090512084801.GA25263@adacore.com> <8ac60eac0905121420t3954685v4b5328d05e072f92@mail.gmail.com>
> 2009-05-12 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * breakpoint.h: Add breakpoint_re_set_objfile prototype.
>
> * breakpoint.c (create_overlay_event_breakpoint): Renamed
> from create_overlay_event_breakpoint_1, old
> create_overlay_event_breakpoint deleted.
> (breakpoint_re_set_objfile): Don't rescan all objfiles
> unnecessarily.
> (breakpoint_re_set): New function.
>
> * symfile.c (new_symfile_objfile): Call breakpoint_re_set_objfile
> instead of breakpoint_re_set.
>
> * objfiles.c (objfile_relocate): Likewise.
Looks good. Just a tiny formatting remark in your ChangeLog: A new line
should be used I think only when the changes are logically unrelated.
--
Joel