This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Add an undwinder_name field to "struct frame_unwind" for use by "info frame".


>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:

Samuel> Have "info frame" display this field when present.
Samuel> Fill in the field for unwinders (besides the sentinel) which are
Samuel> normally built on i386 Linux.

Funnily enough, I wanted this yesterday :)

This mostly looks ok.  It needs a ChangeLog entry.  And I have some
formatting nits...

Samuel> +const char *get_frame_unwinder_name (struct frame_info *frame)

Newline after the first "*".

Samuel> +    unwinder = get_frame_unwinder_name(fi);

Space before the open paren.

Also, do you have copyright assignment papers in place?  Those are a
prerequisite for us to accept a non-trivial patch.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]