This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] nto target: Code cleanup


Mark Kettenis wrote:
From: Aleksandar Ristovski <aristovski@qnx.com>
Date:  Thu, 11 Jun 2009 15:15:56 -0400

Hello,

This patch removes i386_nto_target as unnecessary indirection.

Thanks,

--
Aleksandar Ristovski
QNX Software Systems

ChangeLog:

	* i386-nto-tdep.c (i386_nto_target): Remove definition.
	(init_i386nto_ops): Use macros to set fields to global
	current_nto_target directly.
	(i386nto_init_abi): Remove unused nto_set_target call.
	* nto-tdep.h (nto_set_target): Remove unused declaration.
	* nto-tdep.c (nto_set_target): Remove unused function.

Not sure this is a step in the right direction. This being in a -tdep.c file pretty much makes it impossible to build a multi-arch GDB that supports multiple NTO targets.


The patch functionally doesn't change anything. If you look at nto-tdep.h there is current_nto_target extern which gets set either by macros I used in my patch or indirectly by nto_set_target.


The patch removes the unnecessary indirection since it doesn't do what one might expect.

Note that this approach works for multiarch but will definitely not work once we enable gdb for multiple targets (of different architectures) at the same time, and my patch doesn't change this situation.

Thanks,

--
Aleksandar Ristovski
QNX Software Systems


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]