This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.

From: Ken Werner <ken at linux dot vnet dot ibm dot com>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>, gdb-patches at sourceware dot org
Date: Thu, 18 Jun 2009 11:19:43 +0200
Subject: Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
References: <20090527001157.934BD76BC0@localhost> <m3iqjmt4bn.fsf@fleche.redhat.com> <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> <m3vdniw74z.fsf@fleche.redhat.com> <8ac60eac0906101839t4d3978fyc1c6d3b3e2eccb6e@mail.gmail.com> <8ac60eac0906101842y2d2fc9fco331cb4336d9508d0@mail.gmail.com> <m3zlc80yxc.fsf@fleche.redhat.com> <8ac60eac0906161342m67c30151lc7f685e0eb36e41f@mail.gmail.com> <m3y6rrzyi7.fsf@fleche.redhat.com> <8ac60eac0906161407s6498913cu5e50e930d599be77@mail.gmail.com>

Paul Pluzhnikov wrote:
> On Tue, Jun 16, 2009 at 1:58 PM, Tom Tromey<tromey@redhat.com> wrote:
> 
>> This patch ok.
> 
> So committed.
> 
> Thanks,

Hi,
I noticed gdb/dwarf2-frame.c:1922 (and :1950) calls dwarf2_get_section_info 
with unsigned long* (5th argument). The function expects a bfd_size_type * 
(a pointer to an unsigned long long on my machine). Thus the compiler issues 
a warning and the gdb build fails because of -Werror. Is it sufficient to 
just cast to (bfd_size_type *) or am I missing something?
Regards
-ken

Follow-Ups:
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov

References:
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Tom Tromey
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Tom Tromey
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]