This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Fix for PR gdb/9903 (part 1)


>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:

Samuel> 	* cli/cli-decode.c (apropos_cmd): Fix avoidance of double
Samuel> 	printing.

These two patches look good to me.  Since they are very small I will
commit them (a bit later).  However, future patches, regardless of
size, will have to wait for your paperwork to clear.

In a case like this, where someone else is committing the patch, it is
simpler for us if you send a complete ChangeLog entry, including the
header.  (Or if not simpler, it is at least traditional :-)

Also in this particular case I would add the PR number to the
entry.  Like:

2009-06-17  Samuel Bronson  <naesten@gmail.com>

	PR cli/9930:
	* cli/cli-decode.c (apropos_cmd): Fix avoidance of double
	printing.

This addition means that the commit message will automatically be
logged in bugzilla.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]